Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update Ubuntu images used on CI to 20.04 #19588

Merged
merged 24 commits into from
Dec 4, 2020
Merged

Update Ubuntu images used on CI to 20.04 #19588

merged 24 commits into from
Dec 4, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Nov 26, 2020

Update Ubuntu CI version to 20.04 and Cuda 11.1. This helps ensure MXNet to work well on recent Linux distributions (while ensuring it continues to work well on ancient distributions based on the CentOS7 CI pipeline)

Thanks to @josephevans who unblocked this update via #19017

@leezu leezu requested a review from szha November 26, 2020 01:44
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-cpu, windows-gpu, miscellaneous, sanity, windows-cpu, edge, unix-gpu, clang, website, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2020
@leezu
Copy link
Contributor Author

leezu commented Dec 3, 2020

@mxnet-bot run ci [unix-cpu, unix-gpu]

#19623

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 3, 2020
@leezu leezu merged commit afc76b0 into apache:master Dec 4, 2020
@leezu leezu deleted the 2020-11/ci-ubuntu-2004 branch December 4, 2020 02:58
This was referenced Dec 4, 2020
Closed
Closed
@access2rohit access2rohit mentioned this pull request Feb 17, 2021
Closed
13 tasks
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Feb 19, 2021
@leezu
Update Ubuntu images used on CI to 20.04 (apache#19588)
67a211e 
* Update Ubuntu images used on CI to 20.04

This helps ensure MXNet to work well on recent Linux distributions (while ensuring it continues to work well on ancient distributions based on the CentOS7 CI pipeline)

* Preserve Ubuntu 18.04 images for TensorRT pipeline as NVidia failed to make TensorRT available for Ubuntu 20.04

* Temporarily disable NVML on CI

[2020-12-03T18:33:10.380Z] OSError: /work/mxnet/python/mxnet/../../build/libmxnet.so: undefined symbol: nvmlDeviceGetComputeRunningProcesses_v2
@access2rohit access2rohit mentioned this pull request Feb 19, 2021
Closed
@QueensGambit
Copy link
Contributor

QueensGambit commented Apr 6, 2021 •
edited
Loading

Hi @leezu .
This PR deleted option(USE_CPP_PACKAGE "Build C++ Package" OFF) from CMakeLists.txt which is a breaking change.
I tried for two days to build MXNet from source on Windows, only to find out that my given USE_CPP_PACKAGE=1 option does not exist anymore. The option BUILD_CPP_EXAMPLES =1 also doesn't seem to enable it.

Building the cpp-package on Linux and Mac via the Makefile still works.
Was this intended or done by accident?

@leezu
Copy link
Contributor Author

leezu commented Apr 7, 2021

@QueensGambit the CPP package was removed as part of 2fbec60 as it relied on deprecated APIs. It's pending refactor to be compatible with the supported C APIs. You can follow #20131 for status

This PR removed USE_CPP_PACKAGE as it was missed in 2fbec60

@QueensGambit
Copy link
Contributor

Thanks for the info @leezu .
However, I am a bit confused because I was still able to build the CPP-Package with Intel-MKL back-end on Linux and Mac for MXNet 1.8.0 (2fc0706).

@leezu
Copy link
Contributor Author

leezu commented Apr 7, 2021 •
edited
Loading

You can still use the v1.x branch if you want to have backwards compatibility. For the master branch, contributions are very welcome. You can see #20131 for a current PR that implements the CPP package in the master branch. Note that the master branch is in preparation of MXNet v2, which is not completely backwards compatible with v1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leezu @mxnet-bot @QueensGambit @szha @lanking520